----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2918/#review6598 -----------------------------------------------------------
Ship it! Looks good to me. You will cause a lot of merging headaches though, so please ensure that the patches already on RB get pushed first. - Andreas Hansson On June 25, 2015, 8:15 a.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2918/ > ----------------------------------------------------------- > > (Updated June 25, 2015, 8:15 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10889:364796f29731 > --------------------------- > ruby: rename variables Addr to addr > > Avoid clash between type Addr and variable name Addr. > > > Diffs > ----- > > src/mem/protocol/MESI_Three_Level-L1cache.sm e4f63f1d502d > src/mem/protocol/MESI_Three_Level-msg.sm e4f63f1d502d > src/mem/protocol/MESI_Three_Level-L0cache.sm e4f63f1d502d > src/mem/protocol/MESI_Two_Level-L1cache.sm e4f63f1d502d > src/mem/protocol/MESI_Two_Level-L2cache.sm e4f63f1d502d > src/mem/protocol/MESI_Two_Level-dir.sm e4f63f1d502d > src/mem/protocol/MESI_Two_Level-dma.sm e4f63f1d502d > src/mem/protocol/MESI_Two_Level-msg.sm e4f63f1d502d > src/mem/protocol/MI_example-cache.sm e4f63f1d502d > src/mem/protocol/MI_example-dir.sm e4f63f1d502d > src/mem/protocol/MI_example-msg.sm e4f63f1d502d > src/mem/protocol/MOESI_CMP_directory-L1cache.sm e4f63f1d502d > src/mem/protocol/MOESI_CMP_directory-L2cache.sm e4f63f1d502d > src/mem/protocol/MOESI_CMP_directory-dir.sm e4f63f1d502d > src/mem/protocol/MOESI_CMP_directory-dma.sm e4f63f1d502d > src/mem/protocol/MOESI_CMP_directory-msg.sm e4f63f1d502d > src/mem/protocol/MOESI_CMP_token-L1cache.sm e4f63f1d502d > src/mem/protocol/MOESI_CMP_token-L2cache.sm e4f63f1d502d > src/mem/protocol/MOESI_CMP_token-dir.sm e4f63f1d502d > src/mem/protocol/MOESI_CMP_token-msg.sm e4f63f1d502d > src/mem/protocol/MOESI_hammer-cache.sm e4f63f1d502d > src/mem/protocol/MOESI_hammer-dir.sm e4f63f1d502d > src/mem/protocol/MOESI_hammer-msg.sm e4f63f1d502d > src/mem/protocol/Network_test-cache.sm e4f63f1d502d > src/mem/protocol/Network_test-dir.sm e4f63f1d502d > src/mem/protocol/Network_test-msg.sm e4f63f1d502d > src/mem/protocol/RubySlicc_MemControl.sm e4f63f1d502d > src/mem/ruby/slicc_interface/AbstractController.cc e4f63f1d502d > > Diff: http://reviews.gem5.org/r/2918/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
