-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2936/#review6659
-----------------------------------------------------------



configs/common/HMC.py (line 22)
<http://reviews.gem5.org/r/2936/#comment5759>

    I think this is fine for now. We could always make it four crossbars to 
capture the quadrants.



configs/common/HMC.py (line 56)
<http://reviews.gem5.org/r/2936/#comment5760>

    We should really do this using the clock domains of gem5.



configs/common/HMC.py (line 81)
<http://reviews.gem5.org/r/2936/#comment5761>

    response



configs/common/HMC.py (line 93)
<http://reviews.gem5.org/r/2936/#comment5762>

    Either use the clock domains, or Param.Frequency



src/mem/SConscript (line 49)
<http://reviews.gem5.org/r/2936/#comment5763>

    I would suggest to do this as part of the respective patches



src/mem/SConscript (line 73)
<http://reviews.gem5.org/r/2936/#comment5764>

    Same as above



src/mem/SConscript (line 98)
<http://reviews.gem5.org/r/2936/#comment5765>

    Same as above


- Andreas Hansson


On July 1, 2015, 10:34 a.m., Erfan Azarkhish wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/2936/
> -----------------------------------------------------------
> 
> (Updated July 1, 2015, 10:34 a.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> -------
> 
> The main python script composing a single HMC device as a sub-system and 
> specifying
> all its parameters. I would like to mention that, one can easily instantiate 
> multiple instances of the HMCSystem
> class and build a network of HMCs, but this patch instantiates only one.
> This patch and the subsequent chain of patches aim to model a simple Hybrid 
> Memory Cube device in gem5
> Please apply the complete chain before running the simulation.
> 
> 
> Diffs
> -----
> 
>   configs/common/HMC.py PRE-CREATION 
>   src/mem/SConscript ebb3d0737aa7 
> 
> Diff: http://reviews.gem5.org/r/2936/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Erfan Azarkhish
> 
>

_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to