----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2882/#review6674 -----------------------------------------------------------
can't say I read the whole thing closely, but did see a few minor issues src/mem/coherent_xbar.cc (line 232) <http://reviews.gem5.org/r/2882/#comment5786> I don't get this change src/mem/dram_ctrl.cc (line 646) <http://reviews.gem5.org/r/2882/#comment5787> update comment & dprintf? - Steve Reinhardt On June 25, 2015, 12:29 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2882/ > ----------------------------------------------------------- > > (Updated June 25, 2015, 12:29 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10877:1bd4a8e0a0d1 > --------------------------- > mem: Add clean evicts to improve snoop filter tracking > > This patch adds eviction notices to the caches, to provide accurate > tracking of cache blocks in snoop filters. We add the CleanEvict > message to the memory heirarchy and use both CleanEvicts and > Writebacks with BLOCK_CACHED flags to propagate notice of clean and > dirty evictions respectively, down the memory hierarchy. Note that the > BLOCK_CACHED flag indicates whether there exist any copies of the > evicted block in the caches above the evicting cache. > > The purpose of the CleanEvict message is to notify snoop filters of > silent evictions in the relevant caches. The CleanEvict message > behaves much like a Writeback. CleanEvict is a write and a request but > unlike a Writeback, CleanEvict does not have data and does not need > exclusive access to the block. The cache generates the CleanEvict > message on a fill resulting in eviction of a clean block. Before > travelling downwards CleanEvict requests generate zero-time snoop > requests to check if the same block is cached in upper levels of the > memory heirarchy. If the block exists, the cache discards the > CleanEvict message. The snoops check the tags, writeback queue and the > MSHRs of upper level caches in a manner similar to snoops generated > from HardPFReqs. Currently CleanEvicts keep travelling towards main > memory unless they encounter the block corresponding to their address > or reach main memory (since we have no well defined point of > serialisation). Main memory simply discards CleanEvict messages. > > We have modified the behavior of Writebacks, such that they generate > snoops to check for the presence of blocks in upper level caches. It > is possible in our current implmentation for a lower level cache to be > writing back a block while a shared copy of the same block exists in > the upper level cache. If the snoops find the same block in upper > level caches, we set the BLOCK_CACHED flag in the Writeback message. > > We have also added logic to account for interaction of other message > types with CleanEvicts waiting in the writeback queue. A simple > example is of a response arriving at a cache removing any CleanEvicts > to the same address from the cache's writeback queue. > > > Diffs > ----- > > src/mem/abstract_mem.cc e4f63f1d502d > src/mem/cache/cache.hh e4f63f1d502d > src/mem/cache/cache_impl.hh e4f63f1d502d > src/mem/cache/prefetch/base.cc e4f63f1d502d > src/mem/coherent_xbar.hh e4f63f1d502d > src/mem/coherent_xbar.cc e4f63f1d502d > src/mem/dram_ctrl.cc e4f63f1d502d > src/mem/packet.hh e4f63f1d502d > src/mem/packet.cc e4f63f1d502d > src/mem/snoop_filter.cc e4f63f1d502d > > Diff: http://reviews.gem5.org/r/2882/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
