----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2872/#review6701 -----------------------------------------------------------
Ship it! Ship It! - Steve Reinhardt On June 8, 2015, 4:33 a.m., Andreas Sandberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2872/ > ----------------------------------------------------------- > > (Updated June 8, 2015, 4:33 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10870:b60bc9acc340 > --------------------------- > sim: Make the drain state a global typed enum > > The drain state enum is currently a part of the Drainable > interface. The same state machine will be used by the DrainManager to > identify the global state of the simulator. Make the drain state a > global typed enum to better cater for this usage scenario. > > > Diffs > ----- > > src/sim/system.cc 282c2a89ace8 > src/mem/simple_mem.cc 282c2a89ace8 > src/sim/drain.hh 282c2a89ace8 > src/sim/drain.cc 282c2a89ace8 > src/sim/sim_object.cc 282c2a89ace8 > src/arch/arm/table_walker.cc 282c2a89ace8 > src/cpu/minor/cpu.cc 282c2a89ace8 > src/cpu/o3/cpu.hh 282c2a89ace8 > src/cpu/o3/cpu.cc 282c2a89ace8 > src/dev/arm/flash_device.cc 282c2a89ace8 > src/dev/arm/ufs_device.cc 282c2a89ace8 > src/dev/copy_engine.cc 282c2a89ace8 > src/dev/dma_device.cc 282c2a89ace8 > src/dev/i8254xGBe.hh 282c2a89ace8 > src/dev/i8254xGBe.cc 282c2a89ace8 > src/dev/ide_disk.cc 282c2a89ace8 > src/dev/io_device.cc 282c2a89ace8 > src/dev/ns_gige.cc 282c2a89ace8 > src/dev/pcidev.cc 282c2a89ace8 > src/dev/sinic.cc 282c2a89ace8 > src/mem/cache/base.cc 282c2a89ace8 > src/mem/cache/mshr_queue.cc 282c2a89ace8 > src/mem/dram_ctrl.cc 282c2a89ace8 > src/mem/dramsim2.cc 282c2a89ace8 > src/mem/ruby/system/DMASequencer.cc 282c2a89ace8 > src/mem/ruby/system/RubyPort.cc 282c2a89ace8 > src/mem/ruby/system/Sequencer.cc 282c2a89ace8 > > Diff: http://reviews.gem5.org/r/2872/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Sandberg > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
