----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2871/#review6700 -----------------------------------------------------------
So is the assumption here that, if you're switching memory modes, you will always call switchCpus with do_drain=True? Other than that I don't see where the redundant drain is coming from. Also, if the system is already drained, how long does a redundant drain take? That is, how much are we really saving here? - Steve Reinhardt On June 8, 2015, 4:32 a.m., Andreas Sandberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2871/ > ----------------------------------------------------------- > > (Updated June 8, 2015, 4:32 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10869:996b20e55386 > --------------------------- > python: Remove redundant drain when changing memory modes > > When the Python helper code switches CPU models, it sometimes also > needs to change the memory mode of the simulator. When this happens, > it accidentally tried to drain the simulator despite having done so > already. This changeset removes the redundant drain. > > > Diffs > ----- > > src/python/m5/simulate.py 282c2a89ace8 > > Diff: http://reviews.gem5.org/r/2871/diff/ > > > Testing > ------- > > Long regressions (including switcheroos pass) > > > Thanks, > > Andreas Sandberg > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
