----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2956/#review6750 -----------------------------------------------------------
Ship it! Nice! I've run into at least a couple cases where this would have been really useful. src/mem/slicc/symbols/Func.py (line 63) <http://reviews.gem5.org/r/2956/#comment5843> Non-issue: If you don't expect this property to be used outside of the Func class, you could just replace its uses with self.default_count in checkArguments. - Joel Hestness On July 10, 2015, 4:29 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2956/ > ----------------------------------------------------------- > > (Updated July 10, 2015, 4:29 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10932:0347c75836a0 > --------------------------- > ruby: slicc: use default argument value > Before this patch, while one could declare / define a function with default > argument values, but the actual function call would require one to specify > all the arguments. This patch changes the check for function arguments. > Now a function call needs to specify arguments that are at least as much as > those with default values and at most the total number of arguments taken > as input by the function. > > > Diffs > ----- > > src/mem/slicc/ast/FormalParamAST.py 5c76426fd9ee > src/mem/slicc/ast/FuncDeclAST.py 5c76426fd9ee > src/mem/slicc/symbols/Func.py 5c76426fd9ee > > Diff: http://reviews.gem5.org/r/2956/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
