----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2948/#review6753 -----------------------------------------------------------
Seems fine to me. Any reason you switched from queue to deque? - Nilay Vaish On July 8, 2015, 12:36 p.m., Andreas Sandberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2948/ > ----------------------------------------------------------- > > (Updated July 8, 2015, 12:36 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10919:c83fe54a7ff7 > --------------------------- > dev, x86: Fix serialization bug in the i8042 device > > The i8042 device drops the contents of a PS2 device's buffer when > serializing, which results in corrupted PS2 state when continuing > simulation after a checkpoint. This changeset fixes this bug and > transitions the i8042 model to use the new serialization API that > requires the serialize() method to be const. > > > Diffs > ----- > > src/dev/x86/i8042.hh 5c76426fd9ee > src/dev/x86/i8042.cc 5c76426fd9ee > > Diff: http://reviews.gem5.org/r/2948/diff/ > > > Testing > ------- > > Tested taking checkpoints and restoring from checkpoints. > > > Thanks, > > Andreas Sandberg > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
