----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2954/#review6760 -----------------------------------------------------------
Ship it! ::Like:: I've always thought that it was strange to use array-like syntactic sugar to access non-array objects. The PerfectCache changes in review 2862 would also move away from []. Would be nice to hear AMD's feelings on this change before pushing. - Joel Hestness On July 10, 2015, 4:28 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2954/ > ----------------------------------------------------------- > > (Updated July 10, 2015, 4:28 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10930:8ddd1d80b590 > --------------------------- > ruby: drop the [] notation for lookup function. > > This is in preparation for adding a second arugment to the lookup > function for the CacheMemory class. The change to *.sm files was made using > the following sed command: > > sed -i 's/\[\([0-9A-Za-z._()]*\)\]/.lookup(\1)/' src/mem/protocol/*.sm > > > Diffs > ----- > > src/mem/protocol/MOESI_hammer-cache.sm 5c76426fd9ee > src/mem/protocol/MOESI_CMP_token-L1cache.sm 5c76426fd9ee > src/mem/protocol/MOESI_CMP_token-L2cache.sm 5c76426fd9ee > src/mem/protocol/MOESI_CMP_token-dir.sm 5c76426fd9ee > src/mem/protocol/MESI_Three_Level-L0cache.sm 5c76426fd9ee > src/mem/protocol/MESI_Three_Level-L1cache.sm 5c76426fd9ee > src/mem/protocol/MESI_Two_Level-L1cache.sm 5c76426fd9ee > src/mem/protocol/MESI_Two_Level-L2cache.sm 5c76426fd9ee > src/mem/protocol/MESI_Two_Level-dir.sm 5c76426fd9ee > src/mem/protocol/MI_example-cache.sm 5c76426fd9ee > src/mem/protocol/MI_example-dir.sm 5c76426fd9ee > src/mem/protocol/MOESI_CMP_directory-L1cache.sm 5c76426fd9ee > src/mem/protocol/MOESI_CMP_directory-L2cache.sm 5c76426fd9ee > src/mem/protocol/MOESI_CMP_directory-dir.sm 5c76426fd9ee > src/mem/protocol/MOESI_CMP_directory-dma.sm 5c76426fd9ee > src/mem/protocol/MOESI_hammer-dir.sm 5c76426fd9ee > src/mem/slicc/parser.py 5c76426fd9ee > > Diff: http://reviews.gem5.org/r/2954/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
