----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2968/#review6772 -----------------------------------------------------------
Ship it! The consistency is nice! Thanks! - Joel Hestness On July 14, 2015, 5:31 a.m., Brandon Potter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2968/ > ----------------------------------------------------------- > > (Updated July 14, 2015, 5:31 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10919:9c3f546cbee4 > --------------------------- > syscall_emul: standardized file descriptor name and add return checks. > > The patch clarifies whether file descriptors are host file descriptors or > target file descriptors in the system call code. (Host file descriptors > are file descriptors which have been allocated through real system calls > where target file descriptors are allocated from an array in the Process > class.) > > > Diffs > ----- > > src/sim/syscall_emul.hh 5c76426fd9ee08bca733582c8c2f001a99e7ff5a > src/sim/syscall_emul.cc 5c76426fd9ee08bca733582c8c2f001a99e7ff5a > > Diff: http://reviews.gem5.org/r/2968/diff/ > > > Testing > ------- > > > Thanks, > > Brandon Potter > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
