----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2975/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- Changeset 10917:2d9a52b0e167 --------------------------- cpu, o3: consider split requests for LSQ checksnoop operations This patch enables instructions in LSQ to track two physical addresses for corresponding two split requests. Later, the information is used in checksnoop() to search for/invalidate the corresponding LD instructions. The current implementation has kept track of only the physical address that is referenced by the first split request. Thus, for checksnoop(), the line accessed by the second request has not been considered, causing potential correctness issues. Diffs ----- src/cpu/base_dyn_inst.hh 5c76426fd9ee src/cpu/base_dyn_inst_impl.hh 5c76426fd9ee src/cpu/o3/iew_impl.hh 5c76426fd9ee src/cpu/o3/lsq_unit_impl.hh 5c76426fd9ee Diff: http://reviews.gem5.org/r/2975/diff/ Testing ------- O3-Ruby-timing-FS test was created, and the regression test was done without any issues. Another patch will include the test. Thanks, Hongil Yoon _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
