> On July 16, 2015, 9:53 p.m., Nilay Vaish wrote: > > src/mem/packet.hh, line 532 > > <http://reviews.gem5.org/r/2958/diff/1/?file=47988#file47988line532> > > > > Why drop this? > > Andreas Hansson wrote: > It is never used. Perhaps Jason should have a look :-)
Haha, I haven't either. Thanks for asking, though! I do think we need to be careful just removing functions that seem unused, though I don't have a good alternative. Maybe mark it as deprecated until the next stable release? Or broadcast to the lists specifically asking about this function? We ought to make some formal method here. When are we allowed to clean up functions like this? I don't know the answer. - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2958/#review6779 ----------------------------------------------------------- On July 13, 2015, 3:15 p.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2958/ > ----------------------------------------------------------- > > (Updated July 13, 2015, 3:15 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10921:8177ac19f549 > --------------------------- > mem: Tidy up packet > > Some minor fixes and removal of dead code. Changing the flags to be > enums rather than static const (to avoid any linking issues caused by > the latter). Also adding a getBlockAddr member which hopefully can > slowly finds its way into caches, snoop filters etc. > > > Diffs > ----- > > src/mem/packet.hh 58fbfddff18d > > Diff: http://reviews.gem5.org/r/2958/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
