----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2952/#review6785 -----------------------------------------------------------
Ship it! Looks good! I found a bit more duplicated code in issueNext while reviewing this patch though: http://reviews.gem5.org/r/2977/. - Brandon Potter On July 10, 2015, 4:27 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2952/ > ----------------------------------------------------------- > > (Updated July 10, 2015, 4:27 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10926:74640564fe2d > --------------------------- > ruby: dma sequencer: avoid code duplication > The code in function issueNext() was duplicated in the function makeRequest(). > > > Diffs > ----- > > src/mem/ruby/system/DMASequencer.cc 5c76426fd9ee > > Diff: http://reviews.gem5.org/r/2952/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
