----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2961/#review6790 -----------------------------------------------------------
Ship it! I am fine with the patch. Can we not use the default arguments? - Nilay Vaish On July 13, 2015, 3:17 p.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2961/ > ----------------------------------------------------------- > > (Updated July 13, 2015, 3:17 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10924:324e30066a96 > --------------------------- > mem: Remove unused RequestCause in cache > > This patch removes the RequestCause, and also simplifies how we > schedule the sending of packets through the memory-side port. The > deassertion of bus requests is removed as it is not used. > > > Diffs > ----- > > src/mem/cache/base.hh 58fbfddff18d > src/mem/cache/cache_impl.hh 58fbfddff18d > src/mem/cache/prefetch/queued.cc 58fbfddff18d > > Diff: http://reviews.gem5.org/r/2961/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
