----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2955/#review6793 -----------------------------------------------------------
Ship it! Ship It! - Brandon Potter On July 10, 2015, 4:28 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2955/ > ----------------------------------------------------------- > > (Updated July 10, 2015, 4:28 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10931:8bccb92a3503 > --------------------------- > ruby: slicc: avoid duplicate code for function argument check > Both FuncCallExprAST and MethodCallExprAST had code for checking the arguments > with which a function is being called. The patch does away with this > duplication. Now the code for checking function call arguments resides in the > Func class. > > > Diffs > ----- > > src/mem/slicc/ast/MethodCallExprAST.py 5c76426fd9ee > src/mem/slicc/parser.py 5c76426fd9ee > src/mem/slicc/symbols/Func.py 5c76426fd9ee > src/mem/slicc/ast/FuncCallExprAST.py 5c76426fd9ee > > Diff: http://reviews.gem5.org/r/2955/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
