----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2966/#review6800 -----------------------------------------------------------
src/sim/process.hh (line 164) <http://reviews.gem5.org/r/2966/#comment5873> I think this will break existing SE mode checkpoints. src/sim/process.hh (line 203) <http://reviews.gem5.org/r/2966/#comment5872> I think you should say sim fd and not host fd. src/sim/process.cc (line 297) <http://reviews.gem5.org/r/2966/#comment5874> How does this change help? - Nilay Vaish On July 14, 2015, 5:30 a.m., Brandon Potter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2966/ > ----------------------------------------------------------- > > (Updated July 14, 2015, 5:30 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10917:eafe9bd908a7 > --------------------------- > syscall_emul: file descriptor interface changes > > This patch gets rid of unused Process::dup_fd method and does minor > refactoring in the process class files. The file descriptor max has been > changed to be the number of file descriptors since this clarifies the loop > boundary condition and cleans up the code a bit. The fd_map field has been > altered to be dynamically allocated as opposed to being an array; the > intention here is to build on this is subsequent patches to allow processes > to share their file descriptors with the clone system call. > > > Diffs > ----- > > src/sim/process.hh 5c76426fd9ee08bca733582c8c2f001a99e7ff5a > src/sim/process.cc 5c76426fd9ee08bca733582c8c2f001a99e7ff5a > src/sim/syscall_emul.cc 5c76426fd9ee08bca733582c8c2f001a99e7ff5a > > Diff: http://reviews.gem5.org/r/2966/diff/ > > > Testing > ------- > > > Thanks, > > Brandon Potter > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
