----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1608/#review6851 -----------------------------------------------------------
configs/common/CacheConfig.py (line 51) <http://reviews.gem5.org/r/1608/#comment5913> Sorry to dredge this up, but I've seen a warning a couple of times that is caused by this line due to this import inside the middle of this function. "SyntaxWarning: import * only allowed at module level" I found the following reference which suggests that it should not be possible to do what this code is trying to do. https://docs.python.org/2/whatsnew/2.1.html#pep-227-nested-scopes Is it possible to do this in a different way to get rid of the warning (and make this code work in general)? - Brandon Potter On Jan. 7, 2013, 11:31 a.m., Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1608/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2013, 11:31 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 9457:fd01ef3f4a58 > --------------------------- > config: Remove O3 dependencies > > The default cache configuration script currently import the O3_ARM_v7a > model configuration, which depends on the O3 CPU. This breaks if gem5 > has been compiled without O3 support. This changeset removes the > dependency by only importing the model if it is requested by the > user. As a bonus, it actually removes some code duplication in the > configuration scripts. > > > Diffs > ----- > > configs/common/CacheConfig.py 56610ab73040 > > Diff: http://reviews.gem5.org/r/1608/diff/ > > > Testing > ------- > > > Thanks, > > Ali Saidi > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
