----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2980/#review6871 -----------------------------------------------------------
Ship it! This is a good idea. Thanks! src/mem/ruby/slicc_interface/AbstractCacheEntry.hh (line 79) <http://reviews.gem5.org/r/2980/#comment5941> Minor: For consistency, should these be prepended with 'm_' as member variables? - Joel Hestness On July 19, 2015, 11:42 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2980/ > ----------------------------------------------------------- > > (Updated July 19, 2015, 11:42 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10936:4f568aac2370 > --------------------------- > ruby: adds set and way indices to AbstractCacheEntry > > > Diffs > ----- > > src/mem/ruby/slicc_interface/AbstractCacheEntry.hh 3a925f9856b1 > src/mem/ruby/structures/CacheMemory.hh 3a925f9856b1 > src/mem/ruby/structures/CacheMemory.cc 3a925f9856b1 > > Diff: http://reviews.gem5.org/r/2980/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
