----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2984/#review6876 -----------------------------------------------------------
Ship it! Seems fine to me. Just a minor request below. src/sim/clocked_object.hh (line 222) <http://reviews.gem5.org/r/2984/#comment5944> Minor: Can you please add a comment on this function and ticksToCycles that these should only be used to convert ticks<->cycles over time periods during which it is known that the clockPeriod() has not changed/will not change? They should probably not be used to schedule absolute time events, since frequency changes could throw these off. - Joel Hestness On July 21, 2015, 3:27 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2984/ > ----------------------------------------------------------- > > (Updated July 21, 2015, 3:27 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10944:6cb4c95a0541 > --------------------------- > sim: clocked object: function for converting cycles to ticks. > > > Diffs > ----- > > src/sim/clocked_object.hh f48e72961850 > > Diff: http://reviews.gem5.org/r/2984/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
