[gem5-dev] changeset in gem5: mem: Hit callback delay fix

[David Hashe]

changeset cf35e8b92a5c in /z/repo/gem5
details: http://repo.gem5.org/gem5?cmd=changeset;node=cf35e8b92a5c
description:
        mem: Hit callback delay fix

        This patch was created by Bihn Pham during his internship at AMD.

        There is no need to delay hit callback response messages by a cycle 
because
        the response latency is already incurred in the Ruby protocol. This 
ensures
        correct timing of memory instructions.

diffstat:

 src/mem/ruby/system/RubyPort.cc |  6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diffs (16 lines):

diff -r b51a2a09ac7d -r cf35e8b92a5c src/mem/ruby/system/RubyPort.cc
--- a/src/mem/ruby/system/RubyPort.cc   Mon Jul 20 09:15:18 2015 -0500
+++ b/src/mem/ruby/system/RubyPort.cc   Mon Jul 20 09:15:18 2015 -0500
@@ -469,8 +469,10 @@
     // turn packet around to go back to requester if response expected
     if (needsResponse) {
         DPRINTF(RubyPort, "Sending packet back over port\n");
-        // send next cycle
-        schedTimingResp(pkt, curTick() + rs->clockPeriod());
+        // Send a response in the same cycle. There is no need to delay the
+        // response because the response latency is already incurred in the
+        // Ruby protocol.
+        schedTimingResp(pkt, curTick());
     } else {
         delete pkt;
     }
_______________________________________________
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev