----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3003/#review6901 -----------------------------------------------------------
You can go ahead an ship it, but we'll likely keep this conversation going. There arem more flags our APU model - which we plan to release publically soon - has added as well. - Tony Gutierrez On Aug. 5, 2015, 1:51 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3003/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2015, 1:51 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11001:5b78d01bf635 > --------------------------- > mem: Remove extraneous acquire/release flags and attributes > > This patch removes the extraneous flags and attributes from the > request and packet, and simply leaves the new commands. The change > introduced when adding acquire/release breaks all compatibility with > existing traces, and there is really no need for any new flags and > attributes. The commands should be sufficient. > > This patch fixes packet tracing (urgent), and also removes the > unnecessary complexity. > > > Diffs > ----- > > src/mem/packet.hh cd22d66592bf > src/mem/packet.cc cd22d66592bf > src/mem/request.hh cd22d66592bf > > Diff: http://reviews.gem5.org/r/3003/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
