> On Aug. 10, 2015, 2:18 p.m., Jason Power wrote: > > Out of curiosity does this change any of the regressions? Maybe the random > > tester one? Or was this code stale?
The code will get executed, but would not have any visible effects. I have not tried running regressions, but would be surprised if anything were to change due to this patch. - Nilay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3007/#review6915 ----------------------------------------------------------- On Aug. 9, 2015, 6:25 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3007/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2015, 6:25 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11039:a692042b6e6c > --------------------------- > ruby: remove random seed > > We no longer use the C library based random number generator: random(). > Instead we use the C++ library provided rng. So setting the random seed for > the RubySystem class has no effect. Hence the variable and the corresponding > option are being dropped. > > > Diffs > ----- > > configs/ruby/Ruby.py 863d314f6356 > src/mem/ruby/system/RubySystem.py 863d314f6356 > src/mem/ruby/system/System.hh 863d314f6356 > src/mem/ruby/system/System.cc 863d314f6356 > > Diff: http://reviews.gem5.org/r/3007/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
