> On Aug. 10, 2015, 2:24 p.m., Jason Power wrote: > > src/mem/ruby/network/Network.py, line 42 > > <http://reviews.gem5.org/r/3012/diff/1/?file=48805#file48805line42> > > > > Could you add a help note here? Also, maybe add a comment saying how > > you come up with this number.
Done. - Nilay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3012/#review6916 ----------------------------------------------------------- On Aug. 10, 2015, 4:03 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3012/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2015, 4:03 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11048:00b055093fa3 > --------------------------- > ruby: specify number of vnets for each protocol > The default value for number of virtual networks is being removed. Each > protocol > should now specify the value it needs. > > > Diffs > ----- > > configs/ruby/Network_test.py 863d314f6356 > src/mem/ruby/network/Network.py 863d314f6356 > configs/ruby/MOESI_CMP_token.py 863d314f6356 > configs/ruby/MOESI_hammer.py 863d314f6356 > configs/ruby/MI_example.py 863d314f6356 > configs/ruby/MOESI_CMP_directory.py 863d314f6356 > configs/ruby/MESI_Three_Level.py 863d314f6356 > configs/ruby/MESI_Two_Level.py 863d314f6356 > > Diff: http://reviews.gem5.org/r/3012/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
