----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3001/#review6958 -----------------------------------------------------------
Ship it! Wow... wish I had thought to do this so it could have been checked in with the rest of the MessageBuffer SimObject patch. I hope we can get it in soon. @Brad and/or AMD crew: If you see this review, I'd recommend checking out this patch soon, since it could save some time merging with MessageBuffer changes I just pushed. src/mem/protocol/Network_test-dir.sm <http://reviews.gem5.org/r/3001/#comment5979> Can you please remove this change from the patch? - Joel Hestness On Aug. 3, 2015, 12:14 a.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3001/ > ----------------------------------------------------------- > > (Updated Aug. 3, 2015, 12:14 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11016:efd32f38e069 > --------------------------- > ruby: declare all protocol message buffers as parameters > > MessageBuffer is a SimObject now. There were protocols that still declared > some of the message buffers are variables of the controller, but not as input > parameters. Special handling was required for these variables in the SLICC > compiler. This patch changes this. Now all message buffers are declared as > input parameters. > > > Diffs > ----- > > src/mem/protocol/MESI_Three_Level-L0cache.sm a618349a7953 > src/mem/protocol/MESI_Two_Level-L1cache.sm a618349a7953 > src/mem/protocol/MESI_Two_Level-dir.sm a618349a7953 > src/mem/protocol/MESI_Two_Level-dma.sm a618349a7953 > src/mem/protocol/MI_example-cache.sm a618349a7953 > src/mem/protocol/MI_example-dir.sm a618349a7953 > src/mem/protocol/MI_example-dma.sm a618349a7953 > src/mem/protocol/MOESI_CMP_directory-L1cache.sm a618349a7953 > src/mem/protocol/MOESI_CMP_directory-L2cache.sm a618349a7953 > src/mem/protocol/MOESI_CMP_directory-dir.sm a618349a7953 > src/mem/protocol/MOESI_CMP_directory-dma.sm a618349a7953 > src/mem/protocol/MOESI_CMP_token-L1cache.sm a618349a7953 > src/mem/protocol/MOESI_CMP_token-dir.sm a618349a7953 > src/mem/protocol/MOESI_CMP_token-dma.sm a618349a7953 > src/mem/protocol/MOESI_hammer-cache.sm a618349a7953 > src/mem/protocol/MOESI_hammer-dir.sm a618349a7953 > src/mem/protocol/MOESI_hammer-dma.sm a618349a7953 > src/mem/protocol/Network_test-cache.sm a618349a7953 > src/mem/protocol/Network_test-dir.sm a618349a7953 > src/mem/slicc/symbols/StateMachine.py a618349a7953 > > Diff: http://reviews.gem5.org/r/3001/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
