----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3011/#review6965 -----------------------------------------------------------
src/mem/ruby/network/garnet/BaseGarnetNetwork.hh (line 51) <http://reviews.gem5.org/r/3011/#comment5984> I think these function header changes should be in a separate patch. If anyone has downstream patches that modify these functions, it may be tricky figuring out why these changes were made in this patch. src/mem/ruby/network/garnet/flexible-pipeline/Router.cc (line 364) <http://reviews.gem5.org/r/3011/#comment5985> This change is orthogonal to the patch description. I think it's ok to be in this patch, but should be reflected in the description. - Joel Hestness On Aug. 9, 2015, 6:26 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3011/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2015, 6:26 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11047:7d7ed2b7ecf6 > --------------------------- > ruby: network: drop member m_in_use > > This member indicates whether or not a particular virtual network is in use. > Instead of having a default big value for the number of virtual networks and > then checking whether a virtual network is in use, the next patch removes the > default value and the protocol configuration file would now specify the > number of virtual networks it requires. > > > Diffs > ----- > > src/mem/ruby/network/Network.hh 863d314f6356 > src/mem/ruby/network/Network.cc 863d314f6356 > src/mem/ruby/network/garnet/BaseGarnetNetwork.hh 863d314f6356 > src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.cc 863d314f6356 > src/mem/ruby/network/garnet/fixed-pipeline/SWallocator_d.cc 863d314f6356 > src/mem/ruby/network/garnet/fixed-pipeline/VCallocator_d.cc 863d314f6356 > src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.cc 863d314f6356 > src/mem/ruby/network/garnet/flexible-pipeline/Router.hh 863d314f6356 > src/mem/ruby/network/garnet/flexible-pipeline/Router.cc 863d314f6356 > src/mem/ruby/network/simple/SimpleNetwork.hh 863d314f6356 > src/mem/ruby/network/simple/SimpleNetwork.cc 863d314f6356 > > Diff: http://reviews.gem5.org/r/3011/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
