> On Aug. 14, 2015, 10:37 p.m., Jieming Yin wrote: > > I am glad to see this patch coming out because the current implementation > > is pretty confusing. However, would it be better if we keep the flexibility > > of dynamically adjusting the length of the bitset instead of hardcoding > > NUMBER_BITS_PER_SET? In some systems the number of computation units can go > > beyond 64, but with much fewer LLCs or dirs. That is my main concern.
What you are asking for is not possible with std::bitset since it requires the size to be fixed at compile time. Another option could be to use std::vector<bool>. Somehow my feeling is that vector<bool> is going to slower than bitset. I would say just raise the number of bits per set to whatever you need. Even if you have a small number of shared controllers, I think bitset would be faster than the current implementation. - Nilay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3014/#review6969 ----------------------------------------------------------- On Aug. 9, 2015, 6:26 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3014/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2015, 6:26 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11053:07ad422ebbd9 > --------------------------- > ruby: set: reimplement using std::bitset > The current Set data structure is slow and therefore is being reimplemented > using std::bitset. The maximum limit of 64 on the number of controllers of > each type is being retained. This means that for simulating a system with > more controllers of a given type, one would need to change the value of the > variable NUMBER_BITS_PER_SET > > > Diffs > ----- > > src/mem/protocol/MOESI_hammer-dir.sm 863d314f6356 > src/mem/protocol/RubySlicc_Types.sm 863d314f6356 > src/mem/ruby/common/NetDest.hh 863d314f6356 > src/mem/ruby/common/NetDest.cc 863d314f6356 > src/mem/ruby/common/SConscript 863d314f6356 > src/mem/ruby/common/Set.hh 863d314f6356 > src/mem/ruby/common/Set.cc 863d314f6356 > > Diff: http://reviews.gem5.org/r/3014/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
