> On Aug. 26, 2015, 3:10 p.m., Jason Power wrote: > > This change seems pretty straightforward. Did you actually test > > checkpoint/restore with Ruby? I don't think any of the regressions test it.
Well, I tried... At least in the revision I have checked out, I couldn't checkpoint Ruby without the patch. The good news is that I get the same panic (Runtime Error at MI_example-cache.sm:126: Invalid RubyRequestType.) with the patch. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3051/#review7042 ----------------------------------------------------------- On Aug. 19, 2015, 2:39 p.m., Andreas Sandberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3051/ > ----------------------------------------------------------- > > (Updated Aug. 19, 2015, 2:39 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11049:f2dc54dbf12d > --------------------------- > ruby: Use the const serialize interface in RubySystem > > The new serialization code (kudos to Tim Jones) moves all of the state > mangling in RubySystem to memWriteback. This makes it possible to use > the new const serialization interface. > > This changeset moves the cache recorder cleanup from the checkpoint() > method to drainResume() to make checkpointing truly constant and > updates the checkpointing code to use the new interface. > > > Diffs > ----- > > src/mem/ruby/system/System.hh 110cce93d398 > src/mem/ruby/system/System.cc 110cce93d398 > > Diff: http://reviews.gem5.org/r/3051/diff/ > > > Testing > ------- > > Regressions pass. > > > Thanks, > > Andreas Sandberg > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
