> On Aug. 26, 2015, 2:13 p.m., Jason Power wrote: > > Any chance of keeping this deprecated across a gem5-stable branch? I'm just > > throwing the idea out there. It seems checkpointing would have broken > > already since the name changed. Also, I have no idea what the current state > > of gem5-stable is, so maybe this has already happened. > > Andreas Sandberg wrote: > This is certainly something that we could do. However, I'm not sure if > there is any easy way of generating a deprecation warning if the old > interface is used. > > Is there code in your gem5 branch that depends on this functionality?
No, I don't think so. I agree that with the -Old name that there is no easy way of generating a warning. I'm for committing this as is and maybe next time trying to be more careful about having a deprecation warning. I've been puching things this way, but we should decide as a community how we want to deprecate, and what we want to deprecate. - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3052/#review7043 ----------------------------------------------------------- On Aug. 19, 2015, 1:40 p.m., Andreas Sandberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3052/ > ----------------------------------------------------------- > > (Updated Aug. 19, 2015, 1:40 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11050:f7968cfeb491 > --------------------------- > sim: Get rid of the non-const serialize() method > > The last SimObject using the legacy serialize API with non-const > methods has now been transitioned to the new API. This changeset > removes the serializeOld() methods from the serialization base class > as they are no longer used. > > > Diffs > ----- > > src/sim/serialize.hh 110cce93d398 > src/sim/serialize.cc 110cce93d398 > src/sim/sim_object.cc 110cce93d398 > > Diff: http://reviews.gem5.org/r/3052/diff/ > > > Testing > ------- > > Regressions pass. > > > Thanks, > > Andreas Sandberg > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
