----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3088/#review7091 -----------------------------------------------------------
src/mem/ruby/slicc_interface/AbstractController.cc (line 332) <http://reviews.gem5.org/r/3088/#comment6026> Are there cases where this isn't true? When/why do we create a packet without a request? - Jason Power On Sept. 2, 2015, 1:46 p.m., Joel Hestness wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3088/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2015, 1:46 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11079:65bcb54f11d6 > --------------------------- > ruby: Fix memory leak in AbstractController > > Recent changes to memory access queuing allocate requests for packets sent to > memory controllers, but did not free the requests. Delete requests if they > exist. > > > Diffs > ----- > > src/mem/ruby/slicc_interface/AbstractController.cc 2763a59c73ff > > Diff: http://reviews.gem5.org/r/3088/diff/ > > > Testing > ------- > > > Thanks, > > Joel Hestness > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
