----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3084/#review7096 -----------------------------------------------------------
Ship it! It's too bad none of the code has any comments. - Jason Power On Sept. 2, 2015, 12:53 a.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3084/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2015, 12:53 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11079:d0e52637c510 > --------------------------- > ruby: slicc: derive DataMember class from Var instead of PairContainer > > The DataMember class in Type.py was being derived from PairContainer. A > separate Var object was also created for the DataMember. This meant some > duplication of across the members of these two classes (Var and DataMember). > This patch changes DataMember from Var instead. There is no obvious reason to > derive from PairContainer which can only hold pairs, something that Var class > already supports. The only thing that DataMember has over Var is init_code, > which is being retained. This change would later on help in having pointers > in DataMembers. > > > Diffs > ----- > > src/mem/slicc/symbols/Type.py 2763a59c73ff > > Diff: http://reviews.gem5.org/r/3084/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
