> On Sept. 2, 2015, 7:41 p.m., Jason Power wrote: > > Do you know what this was used for? I've never encountered this, but it > > probably had a good reason to be there at some point... > > Nilay Vaish wrote: > None of the current protocols use it. The line has seen not any changes > since SLICC was first > merged into the repository. I certainly don't like the name of the > 'feature'. I think > it is safe to drop it.
At a minimum we should wait for Brad to comment, since he may know what its purpose was. - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3083/#review7095 ----------------------------------------------------------- On Sept. 2, 2015, 12:52 a.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3083/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2015, 12:52 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11078:249cacaa1d02 > --------------------------- > ruby: slicc: remove nextLineHack from Type.py > > > Diffs > ----- > > src/mem/slicc/symbols/Type.py 2763a59c73ff > > Diff: http://reviews.gem5.org/r/3083/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
