We can do either hg mv, or hg rm and hg add. What is preferred? From: Nilay Vaish [mailto:[email protected]] On Behalf Of Nilay Vaish Sent: Thursday, September 03, 2015 1:51 PM To: Nilay Vaish; Gutierrez, Anthony; Hashe, David; Default Subject: Re: Review Request 2965: rename System.{hh,cc} to RubySystem.{hh,cc}
This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2965/ On September 3rd, 2015, 6:36 p.m. UTC, Tony Gutierrez wrote: Are they comments on this? We'd like to ship this soon. Has hg mv been used to move those two files? - Nilay On July 13th, 2015, 7 p.m. UTC, David Hashe wrote: Review request for Default. By David Hashe. Updated July 13, 2015, 7 p.m. Repository: gem5 Description Changeset 10923:8bdfe8dd9c2b --------------------------- rename System.{hh,cc} to RubySystem.{hh,cc} The eventual aim of this change is to pass RubySystem pointers through to objects generated from the SLICC protocol code. Because some of these objects need to dereference their RubySystem pointers, they need access to the System.hh header file. In src/mem/ruby/SConscript, the MakeInclude function creates single-line header files in the build directory that do nothing except include the corresponding header file from the source tree. However, SLICC also generates a list of header files from its symbol table, and writes it to mem/protocol/Types.hh in the build directory. This code assumes that the header file name is the same as the class name. The end result of this is the many of the generated slicc files try to include RubySystem.hh, when the file they really need is System.hh. The path of least resistence is just to rename System.hh to RubySystem.hh. Diffs * src/mem/ruby/system/RubySystem.cc (PRE-CREATION) * src/mem/slicc/symbols/StateMachine.py (5ee72f4b293152dd0c75ab402a49696d6903e604) * src/mem/ruby/system/System.cc (5ee72f4b293152dd0c75ab402a49696d6903e604) * src/mem/ruby/system/System.hh (5ee72f4b293152dd0c75ab402a49696d6903e604) * src/mem/ruby/system/Sequencer.cc (5ee72f4b293152dd0c75ab402a49696d6903e604) * src/mem/ruby/system/SConscript (5ee72f4b293152dd0c75ab402a49696d6903e604) * src/mem/ruby/system/RubySystem.py (5ee72f4b293152dd0c75ab402a49696d6903e604) * src/mem/ruby/structures/CacheMemory.cc (5ee72f4b293152dd0c75ab402a49696d6903e604) * src/mem/ruby/structures/BankedArray.cc (5ee72f4b293152dd0c75ab402a49696d6903e604) * src/mem/ruby/structures/BankedArray.hh (5ee72f4b293152dd0c75ab402a49696d6903e604) * src/mem/ruby/structures/DirectoryMemory.cc (5ee72f4b293152dd0c75ab402a49696d6903e604) * src/mem/ruby/structures/Prefetcher.hh (5ee72f4b293152dd0c75ab402a49696d6903e604) * src/mem/ruby/system/RubySystem.hh (PRE-CREATION) * src/mem/ruby/system/RubyPort.hh (5ee72f4b293152dd0c75ab402a49696d6903e604) * src/mem/ruby/system/DMASequencer.cc (5ee72f4b293152dd0c75ab402a49696d6903e604) * src/mem/ruby/system/DMASequencer.hh (5ee72f4b293152dd0c75ab402a49696d6903e604) * src/mem/ruby/system/CacheRecorder.cc (5ee72f4b293152dd0c75ab402a49696d6903e604) * src/mem/ruby/structures/WireBuffer.cc (5ee72f4b293152dd0c75ab402a49696d6903e604) * src/mem/ruby/structures/TimerTable.cc (5ee72f4b293152dd0c75ab402a49696d6903e604) * src/mem/ruby/structures/RubyMemoryControl.cc (5ee72f4b293152dd0c75ab402a49696d6903e604) * src/mem/ruby/structures/RubyMemoryControl.hh (5ee72f4b293152dd0c75ab402a49696d6903e604) * src/mem/ruby/structures/Prefetcher.cc (5ee72f4b293152dd0c75ab402a49696d6903e604) * src/mem/slicc/symbols/Type.py (5ee72f4b293152dd0c75ab402a49696d6903e604) * src/mem/ruby/slicc_interface/AbstractController.cc (5ee72f4b293152dd0c75ab402a49696d6903e604) * src/mem/ruby/network/simple/Throttle.cc (5ee72f4b293152dd0c75ab402a49696d6903e604) * src/mem/ruby/network/simple/Throttle.hh (5ee72f4b293152dd0c75ab402a49696d6903e604) * src/mem/ruby/network/simple/SimpleNetwork.cc (5ee72f4b293152dd0c75ab402a49696d6903e604) * src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.cc (5ee72f4b293152dd0c75ab402a49696d6903e604) * src/mem/ruby/network/garnet/fixed-pipeline/OutVcState_d.cc (5ee72f4b293152dd0c75ab402a49696d6903e604) * src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.cc (5ee72f4b293152dd0c75ab402a49696d6903e604) * src/mem/ruby/network/Network.cc (5ee72f4b293152dd0c75ab402a49696d6903e604) * src/mem/ruby/network/MessageBuffer.cc (5ee72f4b293152dd0c75ab402a49696d6903e604) * src/mem/ruby/filters/NonCountingBloomFilter.cc (5ee72f4b293152dd0c75ab402a49696d6903e604) * src/mem/ruby/filters/MultiGrainBloomFilter.cc (5ee72f4b293152dd0c75ab402a49696d6903e604) * src/mem/ruby/filters/LSB_CountingBloomFilter.cc (5ee72f4b293152dd0c75ab402a49696d6903e604) * src/mem/ruby/filters/BulkBloomFilter.cc (5ee72f4b293152dd0c75ab402a49696d6903e604) * src/mem/ruby/filters/BlockBloomFilter.cc (5ee72f4b293152dd0c75ab402a49696d6903e604) * src/mem/ruby/common/DataBlock.cc (5ee72f4b293152dd0c75ab402a49696d6903e604) * src/mem/ruby/common/Address.cc (5ee72f4b293152dd0c75ab402a49696d6903e604) * src/cpu/testers/rubytest/RubyTester.cc (5ee72f4b293152dd0c75ab402a49696d6903e604) * src/cpu/testers/rubytest/Check.cc (5ee72f4b293152dd0c75ab402a49696d6903e604) View Diff<http://reviews.gem5.org/r/2965/diff/> _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
