----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3093/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- Changeset 11080:57bba48b86ae --------------------------- arch: clean up isa_parser error handling Although some decent error messages were getting generated inside isa_parser.py, they weren't always getting printed because of the screwy way we were handling exceptions. (Basically an inner exception would get hidden by an outer exception, and the more informative inner error message would not get printed.) Also line numbers were messed up, since they were taken from the lexer, which is typically a token (or more) ahead of the grammar rule that's being matched. Using the 'lineno' attribute that PLY associates with the grammar production is more accurate. The new LineTracker class extends lineno to track filenames as well as line numbers. Diffs ----- src/arch/isa_parser.py 95eb22928d0fab28a5884ef698a68404b8e5ab1c Diff: http://reviews.gem5.org/r/3093/diff/ Testing ------- Thanks, Steve Reinhardt _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
