----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2525/#review7114 -----------------------------------------------------------
Looks good other than the one minor thing below. src/dev/cirrus.cc (line 131) <http://reviews.gem5.org/r/2525/#comment6030> How about kvmVM(USE_KVM ? p->kvmVM : NULL), I guess kids these days are using nullptr rather than NULL as well - Steve Reinhardt On Sept. 3, 2015, 3:25 p.m., Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2525/ > ----------------------------------------------------------- > > (Updated Sept. 3, 2015, 3:25 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10562:ee3ae920f5b5 > --------------------------- > x86: Add a cirrus graphics adapter to x86 systems. > > This required reworking how the functions which hook up the system are > organized slightly. They really need more a more substantial overhaul, but > that's outside of the scope of this change. > > > Diffs > ----- > > src/dev/Cirrus.py PRE-CREATION > src/dev/SConscript 95eb22928d0f > src/dev/cirrus.hh PRE-CREATION > src/dev/cirrus.cc PRE-CREATION > > Diff: http://reviews.gem5.org/r/2525/diff/ > > > Testing > ------- > > > Thanks, > > Gabe Black > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
