> On Sept. 8, 2015, 5:22 p.m., Nilay Vaish wrote: > > Any more comments before it push this to the repo? > > Jason Lowe-Power wrote: > I agree with Tony that this seems like a lot of changes for a small > benefit. At a minumum I would like to know what the performance benefit > actually is (10% faster, totally worth it, 0.5% faster, I'm not sure). > Additionally, since this really doesn't make any difference until > http://reviews.gem5.org/r/3009 is submitted, I would like to at least wait > until after that patch.
If you're going for performance with this patch, please quantify the benefit to support your claim. If it's not significant, I would prefer to not ship this. - Tony ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3005/#review7131 ----------------------------------------------------------- On Aug. 9, 2015, 11:24 a.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3005/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2015, 11:24 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11032:95ddf324be85 > --------------------------- > ruby: consumer: pass on the current tick to wakeup() function > > This is to avoid calling clockEdge() sometimes. > > > Diffs > ----- > > src/mem/ruby/network/garnet/fixed-pipeline/VCallocator_d.hh 863d314f6356 > src/mem/ruby/network/garnet/fixed-pipeline/VCallocator_d.cc 863d314f6356 > src/mem/ruby/network/garnet/flexible-pipeline/NetworkInterface.hh > 863d314f6356 > src/mem/ruby/network/garnet/flexible-pipeline/NetworkInterface.cc > 863d314f6356 > src/mem/ruby/network/garnet/flexible-pipeline/NetworkLink.hh 863d314f6356 > src/mem/ruby/network/garnet/flexible-pipeline/NetworkLink.cc 863d314f6356 > src/mem/ruby/network/garnet/flexible-pipeline/Router.hh 863d314f6356 > src/mem/ruby/network/garnet/flexible-pipeline/Router.cc 863d314f6356 > src/mem/ruby/network/garnet/flexible-pipeline/VCarbiter.hh 863d314f6356 > src/mem/ruby/network/garnet/flexible-pipeline/VCarbiter.cc 863d314f6356 > src/mem/ruby/network/simple/PerfectSwitch.hh 863d314f6356 > src/mem/ruby/network/simple/PerfectSwitch.cc 863d314f6356 > src/mem/ruby/network/simple/Throttle.hh 863d314f6356 > src/mem/ruby/network/simple/Throttle.cc 863d314f6356 > src/mem/ruby/slicc_interface/AbstractController.hh 863d314f6356 > src/mem/ruby/structures/RubyMemoryControl.hh 863d314f6356 > src/mem/ruby/structures/RubyMemoryControl.cc 863d314f6356 > src/mem/slicc/symbols/StateMachine.py 863d314f6356 > src/mem/ruby/common/Consumer.hh 863d314f6356 > src/mem/ruby/network/garnet/fixed-pipeline/InputUnit_d.hh 863d314f6356 > src/mem/ruby/network/garnet/fixed-pipeline/InputUnit_d.cc 863d314f6356 > src/mem/ruby/network/garnet/fixed-pipeline/NetworkInterface_d.hh > 863d314f6356 > src/mem/ruby/network/garnet/fixed-pipeline/NetworkInterface_d.cc > 863d314f6356 > src/mem/ruby/network/garnet/fixed-pipeline/NetworkLink_d.hh 863d314f6356 > src/mem/ruby/network/garnet/fixed-pipeline/NetworkLink_d.cc 863d314f6356 > src/mem/ruby/network/garnet/fixed-pipeline/OutputUnit_d.hh 863d314f6356 > src/mem/ruby/network/garnet/fixed-pipeline/OutputUnit_d.cc 863d314f6356 > src/mem/ruby/network/garnet/fixed-pipeline/Router_d.cc 863d314f6356 > src/mem/ruby/network/garnet/fixed-pipeline/SWallocator_d.hh 863d314f6356 > src/mem/ruby/network/garnet/fixed-pipeline/SWallocator_d.cc 863d314f6356 > src/mem/ruby/network/garnet/fixed-pipeline/Switch_d.hh 863d314f6356 > src/mem/ruby/network/garnet/fixed-pipeline/Switch_d.cc 863d314f6356 > > Diff: http://reviews.gem5.org/r/3005/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
