----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3026/#review7195 -----------------------------------------------------------
Ship it! src/cpu/o3/iew_impl.hh (lines 132 - 139) <http://reviews.gem5.org/r/3026/#comment6084> Identation is off. - Nilay Vaish On Aug. 11, 2015, 9:05 p.m., Curtis Dunham wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3026/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2015, 9:05 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > This patch adds probe points in Fetch, IEW, Rename and Commit stages as > follows. > > A probe point is added in the Fetch stage for probing when a fetch request is > sent. Notify is fired on the probe point when a request is sent succesfully in > the first attempt as well as on a retry attempt. > > Probe points are added in the IEW stage when an instruction begins to execute > and when execution is complete. This points can be used for monitoring the > execution time of an instruction. > > Probe points are added in the Rename stage to probe renaming of source and > destination registers and when there is squashing. These probe points can be > used to track register dependencies and remove when there is squashing. > > A probe point for squashing is added in Commit to probe squashed instructions. > > > Diffs > ----- > > src/cpu/o3/rename.hh b998b5a6c5f59b41e0c0997ca1bebe37717ad551 > src/cpu/o3/rename_impl.hh b998b5a6c5f59b41e0c0997ca1bebe37717ad551 > src/cpu/o3/iew_impl.hh b998b5a6c5f59b41e0c0997ca1bebe37717ad551 > src/cpu/o3/fetch_impl.hh b998b5a6c5f59b41e0c0997ca1bebe37717ad551 > src/cpu/o3/iew.hh b998b5a6c5f59b41e0c0997ca1bebe37717ad551 > src/cpu/o3/commit.hh b998b5a6c5f59b41e0c0997ca1bebe37717ad551 > src/cpu/o3/commit_impl.hh b998b5a6c5f59b41e0c0997ca1bebe37717ad551 > src/cpu/o3/cpu.cc b998b5a6c5f59b41e0c0997ca1bebe37717ad551 > src/cpu/o3/fetch.hh b998b5a6c5f59b41e0c0997ca1bebe37717ad551 > > Diff: http://reviews.gem5.org/r/3026/diff/ > > > Testing > ------- > > > Thanks, > > Curtis Dunham > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
