----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3119/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- Changeset 11122:1a3619d669d1 --------------------------- ruby: copy data to TBE only when required This patch changes protocols so that data is copied to a TBE only when required. This is required since a later patch drops static variable for block size in RubySystem class. That variable was used for allocating data buffer in the constructor for the DataBlock class. But now that would not happen. Instead a constructor with size argument will be added. Even with that constructor, it is not possible to allocate data block to a cache entry at its construction time. This is because cache entries are allocated in SLICC code and SLICC does not allow defining constructors that can take input arguments. So we cannot supply data block size to the constructor for the Cache Entry. So, from now on we copy data from cache block to TBE only when we know for sure that the cache block has a data block. Diffs ----- src/mem/protocol/MESI_Three_Level-L0cache.sm 5a2e1b1b5c43 src/mem/protocol/MESI_Three_Level-L1cache.sm 5a2e1b1b5c43 src/mem/protocol/MESI_Two_Level-L1cache.sm 5a2e1b1b5c43 src/mem/protocol/MESI_Two_Level-L2cache.sm 5a2e1b1b5c43 src/mem/protocol/MOESI_CMP_directory-L1cache.sm 5a2e1b1b5c43 src/mem/protocol/MOESI_hammer-cache.sm 5a2e1b1b5c43 Diff: http://reviews.gem5.org/r/3119/diff/ Testing ------- Thanks, Nilay Vaish _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
