> On Sept. 21, 2015, 8:03 a.m., Andreas Hansson wrote: > > tests/configs/memtest-ruby.py, line 1 > > <http://reviews.gem5.org/r/3123/diff/1/?file=49668#file49668line1> > > > > Adding is fine, but removing and changing?
The removed ones are in ruby_generic.py. Alternately I can drop them from the new file and keep them in the old one. > On Sept. 21, 2015, 8:03 a.m., Andreas Hansson wrote: > > tests/configs/ruby_generic.py, line 136 > > <http://reviews.gem5.org/r/3123/diff/1/?file=49669#file49669line136> > > > > Why do functional accesses if they don't work? Because they do work mostly. Writes always succeed, reads fail sometimes. > On Sept. 21, 2015, 8:03 a.m., Andreas Hansson wrote: > > tests/configs/ruby_generic.py, line 126 > > <http://reviews.gem5.org/r/3123/diff/1/?file=49669#file49669line126> > > > > RubyMemTest? Does it matter? - Nilay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3123/#review7224 ----------------------------------------------------------- On Sept. 18, 2015, midnight, Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3123/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2015, midnight) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11116:efcde5b8427d > --------------------------- > ruby, regressions: create classes for ruby's different tests. > > We will soon add regression tests that run longer and test garnet networks > and different topologies. > > > Diffs > ----- > > tests/configs/memtest-ruby.py 39219e0eb24c > tests/configs/ruby_generic.py PRE-CREATION > tests/configs/rubytest-ruby.py 39219e0eb24c > > Diff: http://reviews.gem5.org/r/3123/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
