----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3030/#review7228 -----------------------------------------------------------
util/decode_inst_dep_trace.py (lines 73 - 87) <http://reviews.gem5.org/r/3030/#comment6150> I read the code. I think there is some inconsistency in the decoding and the encoding procedures. Typically, the procedures should look like inverses of each other. * When you are writing addr, size and flags, the code in encoding and decoding differs. * PC and weight are not optional in the ascii trace. You write some default values. - Nilay Vaish On Aug. 11, 2015, 9:05 p.m., Curtis Dunham wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3030/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2015, 9:05 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > This patch adds python scripts to parse a protobuf encoded O3CPU > elastic trace and convert it to a text file output and vice versa. > > > Diffs > ----- > > util/decode_inst_dep_trace.py PRE-CREATION > util/encode_inst_dep_trace.py PRE-CREATION > > Diff: http://reviews.gem5.org/r/3030/diff/ > > > Testing > ------- > > > Thanks, > > Curtis Dunham > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
