----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3050/#review7259 -----------------------------------------------------------
Ship it! Seems fine to me. - Nilay Vaish On Aug. 21, 2015, 3:47 p.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3050/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2015, 3:47 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11061:3b40b2d9e2d8 > --------------------------- > mem: Add snoops for CleanEvicts and Writebacks in atomic mode > > This patch mirrors the logic in timing mode which sends up snoops to > check for cached copies before sending CleanEvicts and Writebacks down > the memory hierarchy. In case there is a copy in a cache above, > discard CleanEvicts and set the BLOCK_CACHED flag in Writebacks so > that writebacks do not reset the cache residency bit in the snoop > filter below. > > > Diffs > ----- > > src/mem/cache/cache.hh 842f56345a42 > src/mem/cache/cache.cc 842f56345a42 > src/mem/coherent_xbar.cc 842f56345a42 > > Diff: http://reviews.gem5.org/r/3050/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
