----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3047/#review7268 -----------------------------------------------------------
Ship it! Ship It! - Nilay Vaish On Sept. 23, 2015, 5:38 p.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3047/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2015, 5:38 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11126:1c89381f6775 > --------------------------- > mem: Make the coherent crossbar account for timing snoops > > This patch introduces the concept of a snoop latency. Given the > requirement to snoop and forward packets in zero time (due to the > coherency mechanism), the latency is accounted for later. > > On a snoop, we establish the latency, and later add it to the header > delay of the packet. To allow multiple caches to contribute to the > snoop latency, we use a separate variable in the packet, and then take > the maximum before adding it to the header delay. > > > Diffs > ----- > > src/mem/coherent_xbar.cc a8980f67b3fc > src/mem/packet.hh a8980f67b3fc > src/mem/cache/cache.hh a8980f67b3fc > src/mem/cache/cache.cc a8980f67b3fc > > Diff: http://reviews.gem5.org/r/3047/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
