----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3148/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- Changeset 11165:9f4847667b67 --------------------------- misc: Add explicit overrides and fix other clang >= 3.5 issues This patch adds explicit overrides as this is now required when using "-Wall" with clang >= 3.5, the latter now part of the most recent XCode. The patch consequently removes "virtual" for those methods where "override" is added. The latter should be enough of an indication. As part of this patch, a few minor issues that clang >= 3.5 complains about are also resolved (unused methods and variables). Diffs ----- src/sim/voltage_domain.hh c81401cf5cc2 src/cpu/minor/cpu.hh c81401cf5cc2 src/cpu/minor/func_unit.cc c81401cf5cc2 src/cpu/minor/pipeline.hh c81401cf5cc2 src/cpu/o3/cpu.hh c81401cf5cc2 src/cpu/pred/bpred_unit.hh c81401cf5cc2 src/cpu/simple/atomic.hh c81401cf5cc2 src/cpu/simple/base.hh c81401cf5cc2 src/cpu/simple/timing.hh c81401cf5cc2 src/cpu/testers/traffic_gen/traffic_gen.hh c81401cf5cc2 src/dev/alpha/backdoor.hh c81401cf5cc2 src/dev/alpha/tsunami.hh c81401cf5cc2 src/dev/alpha/tsunami_cchip.hh c81401cf5cc2 src/dev/alpha/tsunami_io.hh c81401cf5cc2 src/dev/alpha/tsunami_pchip.hh c81401cf5cc2 src/dev/copy_engine.hh c81401cf5cc2 src/dev/disk_image.hh c81401cf5cc2 src/dev/dma_device.hh c81401cf5cc2 src/dev/etherlink.hh c81401cf5cc2 src/dev/ethertap.hh c81401cf5cc2 src/dev/i2cbus.hh c81401cf5cc2 src/dev/i8254xGBe.hh c81401cf5cc2 src/dev/ide_ctrl.hh c81401cf5cc2 src/dev/ide_disk.hh c81401cf5cc2 src/dev/ns_gige.hh c81401cf5cc2 src/dev/pcidev.hh c81401cf5cc2 src/dev/sinic.hh c81401cf5cc2 src/dev/uart8250.hh c81401cf5cc2 src/dev/virtio/fs9p.hh c81401cf5cc2 src/mem/abstract_mem.hh c81401cf5cc2 src/mem/cache/cache.hh c81401cf5cc2 src/mem/cache/tags/base_set_assoc.hh c81401cf5cc2 src/mem/cache/tags/fa_lru.hh c81401cf5cc2 src/mem/dram_ctrl.hh c81401cf5cc2 src/mem/dramsim2.hh c81401cf5cc2 src/mem/page_table.hh c81401cf5cc2 src/mem/ruby/network/garnet/fixed-pipeline/GarnetLink_d.py c81401cf5cc2 src/mem/ruby/network/garnet/fixed-pipeline/NetworkLink_d.hh c81401cf5cc2 src/mem/ruby/network/garnet/fixed-pipeline/NetworkLink_d.cc c81401cf5cc2 src/mem/ruby/structures/RubyMemoryControl.hh c81401cf5cc2 src/mem/ruby/system/DMASequencer.hh c81401cf5cc2 src/mem/ruby/system/RubyPort.hh c81401cf5cc2 src/mem/ruby/system/RubySystem.hh c81401cf5cc2 src/mem/simple_mem.hh c81401cf5cc2 src/sim/clock_domain.hh c81401cf5cc2 src/sim/process.hh c81401cf5cc2 src/sim/root.hh c81401cf5cc2 src/sim/sim_events.hh c81401cf5cc2 src/sim/system.hh c81401cf5cc2 src/sim/ticked_object.hh c81401cf5cc2 src/arch/alpha/process.hh c81401cf5cc2 src/arch/alpha/system.hh c81401cf5cc2 src/arch/alpha/tlb.hh c81401cf5cc2 src/arch/arm/table_walker.hh c81401cf5cc2 src/arch/arm/tlb.hh c81401cf5cc2 src/arch/generic/tlb.hh c81401cf5cc2 src/cpu/base.hh c81401cf5cc2 src/cpu/checker/cpu.hh c81401cf5cc2 Diff: http://reviews.gem5.org/r/3148/diff/ Testing ------- Thanks, Andreas Hansson _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
