> On Oct. 12, 2015, 4:58 p.m., Nilay Vaish wrote: > > Can you explain why it is no longer necessary?
Empirically, all regressions still pass. :-) It might be easier to explain why it was ever necessary, which is definitely before my time with gem5. This check was introduced in 2011 (3893d9d) with the comment "make sure fetch doesn't go off into the weeds during speculation". This check is unrealistic and now o3 doesn't have any issues because it can handle whatever faults come from bad fetch requests, as it should. - Curtis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3150/#review7357 ----------------------------------------------------------- On Oct. 12, 2015, 4:13 p.m., Curtis Dunham wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3150/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2015, 4:13 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > This check is no longer necessary. > > > Diffs > ----- > > src/cpu/o3/fetch.hh d90aec9435bd720f2af2ef809680608b3b6955c5 > src/cpu/o3/fetch_impl.hh d90aec9435bd720f2af2ef809680608b3b6955c5 > > Diff: http://reviews.gem5.org/r/3150/diff/ > > > Testing > ------- > > > Thanks, > > Curtis Dunham > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
