changeset 60d4dfa3241a in /z/repo/gem5
details: http://repo.gem5.org/gem5?cmd=changeset;node=60d4dfa3241a
description:
        ruby: remove unused functionalRead() function.

        Not required since functional reads cannot rely on messages that are 
inflight.

diffstat:

 src/mem/ruby/network/MessageBuffer.cc        |  26 --------------------------
 src/mem/ruby/network/MessageBuffer.hh        |   5 -----
 src/mem/ruby/network/simple/SimpleNetwork.cc |   6 ------
 src/mem/ruby/network/simple/Switch.cc        |   6 ------
 4 files changed, 0 insertions(+), 43 deletions(-)

diffs (83 lines):

diff -r 1151cfea92e3 -r 60d4dfa3241a src/mem/ruby/network/MessageBuffer.cc
--- a/src/mem/ruby/network/MessageBuffer.cc     Wed Oct 14 00:29:38 2015 -0500
+++ b/src/mem/ruby/network/MessageBuffer.cc     Wed Oct 14 00:29:39 2015 -0500
@@ -350,32 +350,6 @@
         (m_prio_heap.front()->getLastEnqueueTime() <= current_time));
 }
 
-bool
-MessageBuffer::functionalRead(Packet *pkt)
-{
-    // Check the priority heap and read any messages that may
-    // correspond to the address in the packet.
-    for (unsigned int i = 0; i < m_prio_heap.size(); ++i) {
-        Message *msg = m_prio_heap[i].get();
-        if (msg->functionalRead(pkt)) return true;
-    }
-
-    // Read the messages in the stall queue that correspond
-    // to the address in the packet.
-    for (StallMsgMapType::iterator map_iter = m_stall_msg_map.begin();
-         map_iter != m_stall_msg_map.end();
-         ++map_iter) {
-
-        for (std::list<MsgPtr>::iterator it = (map_iter->second).begin();
-            it != (map_iter->second).end(); ++it) {
-
-            Message *msg = (*it).get();
-            if (msg->functionalRead(pkt)) return true;
-        }
-    }
-    return false;
-}
-
 uint32_t
 MessageBuffer::functionalWrite(Packet *pkt)
 {
diff -r 1151cfea92e3 -r 60d4dfa3241a src/mem/ruby/network/MessageBuffer.hh
--- a/src/mem/ruby/network/MessageBuffer.hh     Wed Oct 14 00:29:38 2015 -0500
+++ b/src/mem/ruby/network/MessageBuffer.hh     Wed Oct 14 00:29:39 2015 -0500
@@ -116,11 +116,6 @@
     void setIncomingLink(int link_id) { m_input_link_id = link_id; }
     void setVnet(int net) { m_vnet_id = net; }
 
-    // Function for figuring out if any of the messages in the buffer can
-    // satisfy the read request for the address in the packet.
-    // Return value, if true, indicates that the request was fulfilled.
-    bool functionalRead(Packet *pkt);
-
     // Function for figuring out if any of the messages in the buffer need
     // to be updated with the data from the packet.
     // Return value indicates the number of messages that were updated.
diff -r 1151cfea92e3 -r 60d4dfa3241a 
src/mem/ruby/network/simple/SimpleNetwork.cc
--- a/src/mem/ruby/network/simple/SimpleNetwork.cc      Wed Oct 14 00:29:38 
2015 -0500
+++ b/src/mem/ruby/network/simple/SimpleNetwork.cc      Wed Oct 14 00:29:39 
2015 -0500
@@ -189,12 +189,6 @@
         }
     }
 
-    for (unsigned int i = 0; i < m_int_link_buffers.size(); ++i) {
-        if (m_int_link_buffers[i]->functionalRead(pkt)) {
-            return true;
-        }
-    }
-
     return false;
 }
 
diff -r 1151cfea92e3 -r 60d4dfa3241a src/mem/ruby/network/simple/Switch.cc
--- a/src/mem/ruby/network/simple/Switch.cc     Wed Oct 14 00:29:38 2015 -0500
+++ b/src/mem/ruby/network/simple/Switch.cc     Wed Oct 14 00:29:39 2015 -0500
@@ -171,12 +171,6 @@
 bool
 Switch::functionalRead(Packet *pkt)
 {
-    // Access the buffers in the switch for performing a functional read
-    for (unsigned int i = 0; i < m_port_buffers.size(); ++i) {
-        if (m_port_buffers[i]->functionalRead(pkt)) {
-            return true;
-        }
-    }
     return false;
 }
 
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to