> On Oct. 21, 2015, 9:45 a.m., Andreas Hansson wrote: > > Can we close the open issues (if they are resolved)? > > > > I also think we should split out the changes to the HMC DRAM config into a > > separate patch. That can then go in with the serial link without having to > > close out the bigger config system issues.
Dear Andreas and Nilay, I can split the patches as you say, but I think it is better to solve this problem now, instead of postponing it to future. I can remove "Subsystem" and insert my components directly in System, but I still don't understand the problem with Subsystem, and why I cannot use it when such functionality is available. I think Subsystem is a perfect mechanism to group related components and introduce some sort of hierarchy. For example a cluster of processors with their caches can be grouped as a subsystem, and one can easily simulate a multi-cluster system by instantiating more subsystems. In my opinion, HMC is another good candidate for a subsystem. Having hierarchical components (components composed of other standard components) can have many benefits and can provie new opportunities to model more complex components (GPUs, Accelerators, Network of HMCs, etc) in a clean and scalable fashion. Please correct me if I'm wrong and help me improve this model. - Erfan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2986/#review7409 ----------------------------------------------------------- On Oct. 18, 2015, 4:31 p.m., Erfan Azarkhish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2986/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2015, 4:31 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11174:6e02b2208e16 > --------------------------- > mem: Simple HMC Model > > This patch enables modeling a complete Hybrid Memory Cube (HMC) device. It > highly reuses the existing components in gem5's general memory system with > some small modifications. This changeset requires an additional patch (2993) > for modeling the serial links. > > > Diffs > ----- > > configs/common/HMC.py PRE-CREATION > configs/common/MemConfig.py 3a4d1b5cd05c > configs/example/fs.py 3a4d1b5cd05c > src/mem/DRAMCtrl.py 3a4d1b5cd05c > src/mem/HMCController.py PRE-CREATION > src/mem/SConscript 3a4d1b5cd05c > src/mem/hmc_controller.hh PRE-CREATION > src/mem/hmc_controller.cc PRE-CREATION > src/mem/xbar.hh 3a4d1b5cd05c > > Diff: http://reviews.gem5.org/r/2986/diff/ > > > Testing > ------- > > gem5 compiles > fs.py executes and Linux boots correctly. > hmctest.py executes correctly, and stats correlate with cycle-accurate > simulation > > > Thanks, > > Erfan Azarkhish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
