----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3013/#review7417 -----------------------------------------------------------
Hello Nilay, I've tried to take this patch and apply it and I ran into two issues: one during compilation and one during runtime. Regarding compilation, "Stats::collate" does not exist and it's not defined in the patch. I have added "const FlagsType collate = 0x0800;" to src/base/stats/info.hh and it fixes this problem. Regarding runtime, the Python code that does the collation for the RubySystem statistics doesn't work properly. When the stats are being written out to the output file with output.visit(ruby_stats_output), there's a complaint that the argument is not a statistic; it's complaining because the argument is a string. Did you have a way to obviate this? Was it even manifesting for you? - Brandon Potter On Sept. 15, 2015, 8:08 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3013/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2015, 8:08 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11104:e41389efcf57 > --------------------------- > ruby: convert global statistical variables to local ones. > Several statistical quantities collected by ruby where recorded / published > using global variables. Since we want to have multiple ruby systems working > together, this is a hindrance. Hence, we are convert such global variables to > local ones. > > The src/python/m5/stats/__init__.py is being updated so that we go over ruby > stats and collate them as required. It seems to me that we should have a > general way in which we can tailor the stats in python just before they are > sent to output. > > > Diffs > ----- > > src/mem/ruby/slicc_interface/AbstractController.hh 38f6188421e0 > src/mem/ruby/slicc_interface/AbstractController.cc 38f6188421e0 > src/mem/slicc/symbols/StateMachine.py 38f6188421e0 > src/python/m5/stats/__init__.py 38f6188421e0 > > Diff: http://reviews.gem5.org/r/3013/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
