----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3184/#review7464 -----------------------------------------------------------
Ship it! I guess I'm okay with this code going in. However, in general, I really dislike renaming a C++ STL types just so that we can use them within SLICC (both BoolVec and IntVec). This obfuscates what these objects do by dissociating them from their C++ counterparts. This is especially painful for type-templated data structures, because you'll eventually need to declare a separate RubySlicc type for every container type you need inside SLICC. We should really find a clearer way to do this. - Joel Hestness On Oct. 30, 2015, 9:52 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3184/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2015, 9:52 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11190:0cb3f3e3f753 > --------------------------- > ruby: add BoolVec > > The BoolVec typedef and insertion operator overload function simplify usage of > vectors of type bool > > > Diffs > ----- > > src/mem/ruby/common/SConscript 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > src/mem/ruby/slicc_interface/RubySlicc_Util.hh > 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > src/mem/protocol/RubySlicc_Util.sm 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > src/mem/ruby/SConscript 4daf60db14d794e2344a6c86a93bdd8273bc5bb6 > src/mem/ruby/common/BoolVec.hh PRE-CREATION > src/mem/ruby/common/BoolVec.cc PRE-CREATION > > Diff: http://reviews.gem5.org/r/3184/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
