----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3169/#review7469 -----------------------------------------------------------
Ship it! Ship It! - Steve Reinhardt On Oct. 26, 2015, 11:13 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3169/ > ----------------------------------------------------------- > > (Updated Oct. 26, 2015, 11:13 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11178:297a63e7b162 > --------------------------- > mem: Unify delayed packet deletion > > This patch unifies how we deal with delayed packet deletion, where the > receiving slave is responsible for deleting the packet, but the > sending agent (e.g. a cache) is still relying on the pointer until the > call to sendTimingReq completes. Previously we used a mix of a > deletion vector and a construct using unique_ptr. With this patch we > ensure all slaves use the latter approach. > > > Diffs > ----- > > src/mem/cache/cache.hh 741b3059946e > src/mem/cache/cache.cc 741b3059946e > src/mem/coherent_xbar.hh 741b3059946e > src/mem/tport.cc 741b3059946e > src/mem/coherent_xbar.cc 741b3059946e > src/mem/dram_ctrl.hh 741b3059946e > src/mem/dram_ctrl.cc 741b3059946e > src/mem/dramsim2.hh 741b3059946e > src/mem/dramsim2.cc 741b3059946e > src/mem/simple_mem.hh 741b3059946e > src/mem/simple_mem.cc 741b3059946e > src/mem/tport.hh 741b3059946e > > Diff: http://reviews.gem5.org/r/3169/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
