----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3171/#review7470 -----------------------------------------------------------
Ship it! Ship It! - Steve Reinhardt On Oct. 30, 2015, 3:33 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3171/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2015, 3:33 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11186:7e65c276ca2d > --------------------------- > mem: Do not treat CleanEvict as a write operation > > This patch changes the CleanEvict command type to not be considered a > write. Initially it was made a zero-sized write to match the writeback > command, but as things developed it became clear that it causes more > problems than it solves. For example, the memory modules (and bridge) > should not consider the CleanEvict as a write, but instead discard > it. With this patch it will be neither a read, nor write, and as it > does not need a response the slave will simply sink it. > > > Diffs > ----- > > src/mem/cache/base.hh 4daf60db14d7 > src/mem/packet.cc 4daf60db14d7 > > Diff: http://reviews.gem5.org/r/3171/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
