> On Nov. 5, 2015, 4:49 p.m., Joel Hestness wrote: > > Can you please expand on the description? Is this for building something in > > ext/? If not, the build files should end up in build/, so I don't support > > this change. If it is for something in ext/, I'd prefer that the ignores > > are more specific than all .a and .o files. > > Tony Gutierrez wrote: > .o and .a files are typically left in util/m5/ > > Joel Hestness wrote: > Ok, in that case, can you please change these ignores to util/m5/*.a and > util/m5/*.o? That way, .a and .o files generated elsewhere will still by > visible with hg status, so a user will be aware that they've added/modified > files.
Sure. I won't repost the patch, but I'll ship with your suggestion. - Tony ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3199/#review7515 ----------------------------------------------------------- On Nov. 5, 2015, 3:46 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3199/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2015, 3:46 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11188:2912767b09d8 > --------------------------- > misc: add object files and static libs to .hgignore > > > Diffs > ----- > > .hgignore 854e61d5390e3bee8864848465fab311e95b9759 > > Diff: http://reviews.gem5.org/r/3199/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
