> On Nov. 8, 2015, 3:45 a.m., Ali Saidi wrote: > > Ship It!
Wait, wait... in line with the recent discussions of Chesterton's fence, I would very much like to understand how that TBR got there in the first place. We have a conditinal over the PSTATE.AM flag; the 64-bit branch only makes sense in V9. How did it ever work? A more general problem that I see with the remote gdb code is that too much is shared statically between the 64-bit and the 32-bit cases. For example, the gdb_regs.size is initialized in the constructor to the largest safe value, because at that point in time it's too early to know the value of PSTATE.AM. I also think that we should have separate RegisterConstants32 and RegisterConstants64. A similar problem is seen in ARM: GDB_REG_BYTES is taken to avoid overfilling the buffer, but then all the extra empty space is transmitted on the wire causing gdb to complain. I will provide a patch addressing this within the next day or so. - Boris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3200/#review7531 ----------------------------------------------------------- On Nov. 7, 2015, 9:22 p.m., Palle Lyckegaard wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3200/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2015, 9:22 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > sparc: Make remote debugging with gdb work - remove sparc V8 TBR register > from list of registers since it is not part of sparc V9. This brings the > number of registers in sync with what gdb expects > > > Diffs > ----- > > src/arch/sparc/remote_gdb.hh UNKNOWN > > Diff: http://reviews.gem5.org/r/3200/diff/ > > > Testing > ------- > > Without this patch gdb complains about receoved packet too long. > > with this patch gdb is able to work properly with gem5 for remote debugging. > > Note: gdb is version 7.8 > Note: gdb is configured with --target=sparc64-sun-solaris2.8 > > > Thanks, > > Palle Lyckegaard > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
